fix: export AxiosError at top-level #5066
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed from exporting AxiosError as both type and value. Renamed AxiosError class type to be AxiosErrorType instead. BREAKING CHANGE: AxiosError type is now AxiosErrorType to prevent from confliciting value and type
mljlynch
reviewed
Oct 8, 2022
| common: AxiosHeaders; | ||
| } | ||
|
|
||
| type AxiosHeaderMatcher = (this: AxiosHeaders, value: string, name: string, headers: RawAxiosHeaders) => boolean; | ||
| type AxiosHeaderMatcher = ( |
There was a problem hiding this comment.
nit: the linter seems to conflict with what is native to this project
haneenmahd
changed the title
Currently, there is no way to use AxiosError correctly. This was caused only by exporting the type at the top-level but the implementation deep inside the axios instance. Exported the AxiosError class at the top-level to fix inconsistencies. Refs: axios#5062 BREAKING CHANGE: AxiosError should be used from the top-level import rather than using it from the axios instance.
|
I believe this has been solved, please open a new PR if not and add me to review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed from exporting AxiosError as both type and value. Renamed
AxiosErrorclass type to beAxiosErrorTypeinstead.This was made so that there less conflicts when using a value and type together. This fixes and makes a way correct way of using
AxiosError.Refs: #5062