Refactored AxiosHeaders class to fix #5067; #5169
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has potential breaking changes in AxiosHeaders class.
defaultHeaders
);concat
method to merge headers into a new instance. This is a functional replacement to merge with defaults externally. This change greatly simplifies the implementation and makes class usage more transparent.set
method (as well as the class constructor) now accepts aAxiosHeaders
instance and raw headers string as the sourcetoString
to serialize into a raw headers stringundefined
, notapplication/x-www-form-urlencoded
. This step makes it easier to keep track of user-defined header values, which in turn simplifies the implementation of the AxiosHeaders class. However, the content header will still be added before the request is sent if it is not explicitly defined or disabled by the user. Only the place and method of adding this header inside the Axios have been changed.Closes #5157;
Closes #5067;
Closes #5006;