fix: decompress response data #5300
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffersonfelixdev
force-pushed
the
fix/decompress-http
branch
from
95c7fbf
to
e5c959a
Compare
|
Please review my test at #5299 (which looks reasonable but |
|
Your test is passing :( BUT, when I add: |
jeffersonfelixdev
force-pushed
the
fix/decompress-http
branch
from
e5c959a
to
24a739b
Compare
|
Using test provided by @ddugovic and added the header 'Transfer-Encoding' I can reproduce the error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #5296 and fixes #5298.
@ddugovic created a test to reproduce this problem. In fact,
content-lenghtis undefined in most of cases when using gzip compression andtransfer-encodingis set tochunked. In this case, I tried to verify the presence oftransfer-encoding(but not sure if it's correct).BTW, this PR does not break the test created on #5250.
I think it's ready to merge.