Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename types responseEncoding to ResponseEncoding #5359

Open
wants to merge 1 commit into
base: v1.x
Choose a base branch
from
Open

fix: rename types responseEncoding to ResponseEncoding #5359

wants to merge 1 commit into from

Conversation

wootsbot
Copy link

@wootsbot wootsbot commented Dec 8, 2022 •
edited

Renaming the type responseEncoding to the correct typescript convention for a type ResponseEncoding name

-  type responseEncoding =
+  type ResponseEncoding =
    | 'ascii' | 'ASCII'
...



  interface AxiosRequestConfig<D = any> {
...
-    responseEncoding?: responseEncoding | string;
+    responseEncoding?: ResponseEncoding | string;

@wootsbot
Copy link
Author

Is there anything else I should do to make it a valid PR ?, 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexiaokang hexiaokang hexiaokang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wootsbot @hexiaokang