Adding 'progress' config option for monitoring uploads and downloads #96
+28
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The suggestion in #82 also suggests a different method signature that would require parsing the event and passing |
|
@mzabriskie Just wanted to check in on this. If there's anything you'd like me to change/update, please let me know. Happy to discuss other options if this doesn't fit into your roadmap. Thanks! |
…ds and downloads.
|
@mzabriskie @barberdt This would be very useful to me also. Anything we can do to make it to official release? |
|
@mzabriskie Can this be merged please? @mzabriskie are you still maintaining axios? |
|
+1, please merge. |
|
+1 |
1 similar comment
|
+1 |
|
+1 why this PR is not merged yet... |
|
👍 |
Closed
|
+1 |
3 similar comments
|
+1 |
|
+1 |
|
+1 |
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #82.
Notes
uploadexample code to include this new option.progressvsonProgressvs (any other name). No opinion or preference here.transformRequest/Response. There does not seem to be a good default, so no need to merge arrays. However, if consistency is important there, happy to change it.