Feature: Migrating to gtag.js #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed legacy comment
|
That's awesome, thank you so much @UndefinedOffset! I'll review the changes and merge over the weekend 👍 I'm guessing that I forgot to push my branch after making those 3.1.6 changes & release 👎 Good spotting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per our discussion in #9 I believe this should do the move to gtag.js. I did end up removing the caching system that you mentioned in part because gtag seems to change from tracking id to tracking id which is interesting. Since it changes from ID to ID I've added a new config option that sets the default tracking id which is the one used in the url, it's optional and defaults to the first one in the
Axllent\AnalyticsJS\AnalyticsJS.trackerconfig.I also included a couple commits that where in the 3.1.6 tag but not anywhere else in the repo :)