Skip to content

Commit

Permalink
Add packaging to requirements
Browse files Browse the repository at this point in the history
  • Loading branch information
@axnsan12
axnsan12 committed Jul 16, 2019
1 parent bc93167 commit e6219ab
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions requirements/base.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ ruamel.yaml>=0.15.34
inflection>=0.3.1
six>=1.10.0
uritemplate>=3.0.0
packaging

This comment has been minimized.

Sign in to view

Copy link
@kjagiello

kjagiello Jul 17, 2019

Shouldn't this be pinned?

This comment has been minimized.

Sign in to view

Copy link
@axnsan12

axnsan12 Jul 17, 2019

Author Owner

I would assume any version works. It is used just for Version comparisons. Should be automatically installed by setuptools anyways.

This comment has been minimized.

Sign in to view

Copy link
@kammala

kammala Jul 22, 2019

It is not required to have setuptools installed anymore since PEP-518.

This comment has been minimized.

Sign in to view

Copy link
@flyudvik

flyudvik Aug 3, 2019

There is somekind of missmatch of setup.py and source code installed, as I installed from PyPI and having import errors for packaging not being defined in setup.py 1.16.1

This comment has been minimized.

Sign in to view

Copy link
@johnthagen

johnthagen Aug 8, 2019

Collaborator

@flyudvik This is a known regression, and will require a 0.16.2 release. Please follow #412

djangorestframework>=3.8
Django>=1.11.7

0 comments on commit e6219ab

Please sign in to comment.