Fix missing assignment for default in openapi.Parameter

axnsan12 · Feb 22, 2018 · f15e70b · f15e70b
1 parent 64c280e
commit f15e70b
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 2 deletions.
diff --git a/docs/changelog.rst b/docs/changelog.rst
@@ -2,6 +2,14 @@
 Changelog
 #########
 
+
+*********
+**1.4.3**
+*********
+
+- **FIXED:** added a missing assignment that would cause the ``default`` argument to ``openapi.Parameter.__init__`` to
+  be ignored
+
 *********
 **1.4.2**
 *********

diff --git a/src/drf_yasg/openapi.py b/src/drf_yasg/openapi.py
@@ -396,6 +396,7 @@ def __init__(self, name, in_, description=None, required=None, schema=None,
         self.enum = enum
         self.pattern = pattern
         self.items = items
+        self.default = default
         self._insert_extras__()
         if self['in'] == IN_PATH:
             # path parameters must always be required

diff --git a/testproj/articles/serializers.py b/testproj/articles/serializers.py
@@ -31,7 +31,7 @@ class Meta:
 
 
 class ImageUploadSerializer(serializers.Serializer):
-    what_am_i_doing = serializers.RegexField(regex=r"^69$", help_text="test")
+    what_am_i_doing = serializers.RegexField(regex=r"^69$", help_text="test", default="69")
     image_styles = serializers.ListSerializer(
         child=serializers.ChoiceField(choices=['wide', 'tall', 'thumb', 'social']),
         help_text="Parameter with Items"

diff --git a/tests/reference.yaml b/tests/reference.yaml
@@ -198,9 +198,10 @@ paths:
         - name: what_am_i_doing
           in: formData
           description: test
-          required: true
+          required: false
           type: string
           pattern: ^69$
+          default: '69'
         - name: image_styles
           in: formData
           description: Parameter with Items