Fix x-nullable on serializers with allow_null=True
#566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance of merging this any time soon? |
I think @axnsan12 has either been burnt out or is affected by everything that's going on (directly or indirectly), since they haven't done anything with this repo since Feb |
|
Makes sense to me, thanks. |
terencehonles
deleted the
fix-x-nullable-on-serializers-with-allow-null
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows
x-nullableon serializers. As originally implemented in #217 I believe this was too strict. Therequiredinstance_kwargsin this context are the fields that are required not if the field is required or not. According to the openapi spec the parent should be managing if the child is required and therefore this shouldn't even be checkingfield.requiredeither.