Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Provide support for enums in codecs. #837

Merged
merged 8 commits into from Mar 16, 2023

Conversation

onegreyonewhite
Copy link
Contributor

We ran into bugs when using Enum objects in inspectors. Due to this problem, the schema could not be rendered via the generate_swagger command.

@onegreyonewhite
Copy link
Contributor Author

I decided to immediately add tests for Python 3.11.

@onegreyonewhite
Copy link
Contributor Author

@JoelLefkowitz The project needs a goooood refactoring... ))

@onegreyonewhite
Copy link
Contributor Author

@JoelLefkowitz ping

@JoelLefkowitz
Copy link
Collaborator

Hey @onegreyonewhite, looks like unit tests failed for the python3.8, fancy having a look?

@onegreyonewhite
Copy link
Contributor Author

@JoelLefkowitz

looks like unit tests failed for the python3.8, fancy having a look?

It was not the tests that were broken, but the documentation. I have no idea how it used to work. Perhaps this test was simply not checked before, and I fixed its launch. Take a look.

@onegreyonewhite
Copy link
Contributor Author

@JoelLefkowitz can you approve CI run?

@onegreyonewhite
Copy link
Contributor Author

@JoelLefkowitz I finally found and solved the problem: the old mechanism does not work with the new tox. I think it is necessary to solve the problem of new tox in a separate PR.

Please, approve PR and check the code.

@onegreyonewhite
Copy link
Contributor Author

@JoelLefkowitz it becomes to hard to maintain this PR )) Started from enums and ended with refactoring, fixing bugs and CI and added support for feature django version.

I fixed dj-master tests. Django master branch bumped minimal python version to Python 3.10. In latest version was added check for uniq basename. That's was fixed and I think it's enough for this PR ;) Please, approve it and release it.

Django master branch bumped minimal python version
to Python 3.10. In latest version was added check for uniq basename.
@JoelLefkowitz JoelLefkowitz merged commit 353f071 into axnsan12:1.21.x Mar 16, 2023
5 checks passed
@JoelLefkowitz
Copy link
Collaborator

@onegreyonewhite Thanks for the contribution :)

@StevenMapes
Copy link

Also includes the equivalent changes from my PR for the older #836 so that's been closed now support is being tested :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants