fix: zip needs unix paths #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZIP expects unix-style paths here, and passing Windows paths will cause incorrect and broken files to be added to the directory. The `zip` crate's `start_file_from_path` and `add_directory_from_path` normalize these, but they were deprecated without replacement so we need to do the work ourselves. Fixes axodotdev/cargo-dist#873.
mistydemeo
force-pushed
the
zip_unix_paths
branch
from
dd14197
to
690a1be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZIP expects unix-style paths here, and passing Windows paths will cause incorrect and broken files to be added to the directory.
The
zipcrate'sstart_file_from_pathandadd_directory_from_pathnormalize these, but they were deprecated without replacement so we need to do the work ourselves.Fixes axodotdev/cargo-dist#873.