fix: bin_aliases should come from packages #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gankra
approved these changes
May 9, 2024
It's possible for packages to have their own specific bin_aliases. We should always read from the package metadata version and skip the workspace version. Since we clone the workspace value into the package if the package has no version to compare to, that's safe.
mistydemeo
force-pushed
the
use_package_specific_bin_aliases
branch
from
f1cb9f6
to
e611026
Compare
| @@ -1729,7 +1729,7 @@ impl<'pkg_graph> DistGraphBuilder<'pkg_graph> { | |||
| warn!("skipping shell installer: not building any supported platforms (use --artifacts=global)"); | |||
| return; | |||
| }; | |||
| let bin_aliases = self.inner.bin_aliases.for_targets(&target_triples); | |||
There was a problem hiding this comment.
where does this change come from?
There was a problem hiding this comment.
We used to look up the workspace value from the DistGraph (self.inner), but now we're reading it from release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for packages to have their own specific bin_aliases. We should always read from the package metadata version and skip the workspace version. Since we clone the workspace value into the package if the package has no version to compare to, that's safe.