fix: repair and cleanup npm binary caching #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Gankra
commented
May 15, 2024
•
Gankra
commented
- this.binaryPath no longer exists, which was causing us to refetch every time
- Package.run already calls Package.install as a subroutine, there's no need to call it again and duplicate the work (potentially we could also remove that, but hey integrity checks are nice?)
- The additional logic in run to select a binary to call was an artifact of development, and never actually ran (trivially provable by nothing ever omitting the argument) (this logic is performed by npx itself because we populated package.json's 'bins')
mistydemeo
requested changes
May 15, 2024
mistydemeo
reviewed
May 15, 2024
* this.binaryPath no longer exists, which was causing us to refetch every time * Package.run already calls Package.install as a subroutine, there's no need to call it again and duplicate the work (potentially we could also remove that, but hey integrity checks are nice?) * The additional logic in un to select a binary to call was an artifact of development, and never actually ran (trivially provable by nothing ever omitting the argument) (this logic is performed by npx itself because we populated package.json's 'bins')
mistydemeo
approved these changes
May 15, 2024
mistydemeo
added a commit
that referenced
this pull request
May 15, 2024
Incorporates the npm cache fix in #1050.
ashleygwilliams
pushed a commit
that referenced
this pull request
May 20, 2024
Incorporates the npm cache fix in #1050.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.