feat: fetch updater without GitHub API call #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of querying releases and using that to see if an asset is available for our architecture, just manually construct the URL and use a HEAD request to see if it exists or not.
mistydemeo
force-pushed
the
fetch-updater-without-api-call
branch
from
5a82089
to
8d4ad2b
Compare
|
Confirmed this works: https://github.com/mistydemeo/cargodisttest/actions/runs/9102514810 |
ashleygwilliams
approved these changes
May 16, 2024
There was a problem hiding this comment.
so i love this strategy. i have known APIs to be weird about HEAD requests... so we should keep an eye on it. if people keep good hygiene it should work well and fine, but people do weird stuff lol. e.g. https://community.cloudflare.com/t/when-cache-everything-head-requests-will-be-turned-into-get-requests/363090
|
We can definitely keep an eye on GitHub's behaviour here and hope they don't accidentally make a weird mistake 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of querying releases and using that to see if an asset is available for our architecture, just manually construct the URL and use a HEAD request to see if it exists or not.
This should improve reliability when checking for new updater releases as a part of the local build process.