add basic support for shasums #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently hardcoded to sha256sum, but with sha512sum implemented. next commit will add config fixes #119
|
Oh I guess this drive-by fixes #200 by just not describing the artifact anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now default generate .sha256 checksum files (one for each archive). Example:
A new
checksum = "..."config has been added, accepting 3 values:All checksums are implemented with the sha2 crate and match sha256sum and sha512sum's hashes. The resulting file is just a lowercase hex string of the hash (no filename included, since each file gets its own .sha256 file). I've defaulted to sha256 since that seems to be the default other people use, and if you're really serious about hardening this stuff you probably want actual signing/pki backing this up (like #120).
I've also cleaned up the Github Release table output a bit as part of this.