New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow overriding install path #837
Conversation
is there any reason to do this an env-var and not a cli flag..? i suppose for curl-sh it's harder |
This also strikes me as a power user/internal feature, which feels better-suited to being an environment variable instead of a CLI flag. |
It is a power-user feature, but it's also an end-power-user feature, right? like they won't even know what "cargo-dist" is? |
I don't think end users should use this; this is a feature for the updater which needs fine-grained control over installation location. That other people can use it is kind of a bonus. |
oh I thought this was also motivated by some other astral asks to let the end-user install to a custom dir... |
Oh, I think I totally missed that side of the conversation. |
11294af
to
ac8ef06
Compare
One more factor: the shell installer errors on unrecognized flags. An environment variable helps us guard against the possibility of using an installer version that doesn't recognize the new flag, because it'll silently ignore the instruction instead of hard-erroring and not performing the install. eg $ ./axolotlsay-installer.sh --force-install-prefix /tmp/axolotlsay
ERROR: unknown option --force-install-prefix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one issue but basic idea seems fine
ac8ef06
to
b01895b
Compare
This provides a way to override any configuration on the installer and install to a location specified by a new environment variable. It provides a more predictable way to insist that it gets installed to a specific place, regardless of how the installer was built. Possible fix for axodotdev/axoupdater#32, where we'd like to be able to install a new version to exactly the same path as the previous version.
b01895b
to
6016b98
Compare
This provides a way to override any configuration on the installer and install to a location specified by a new environment variable. It provides a more predictable way to insist that it gets installed to a specific place, regardless of how the installer was built.
Possible fix for axodotdev/axoupdater#32, where we'd like to be able to install a new version to exactly the same path as the previous version.