chore: add ruin_me powershell tests #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gankra
commented
Mar 20, 2024
cargo-dist/tests/gallery/dist.rs
Outdated
Comment on lines
580
to
608
| // check the install receipts | ||
| // FIXME: temporarily disabled for the feature being broken | ||
| // self.check_install_receipt(ctx, &bin_dir, &receipt_file, ".exe"); |
There was a problem hiding this comment.
todo for @mistydemeo: fix install receipts and uncomment this line
There was a problem hiding this comment.
Rebase with this uncommented works: #866
There was a problem hiding this comment.
You can reenable this now that #863 is merged.
Gankra
force-pushed
the
ruin_ps1
branch
2 times, most recently
from
79a4725
to
22f24cd
Compare
Closed
mistydemeo
approved these changes
Mar 21, 2024
| &tempdir, | ||
| "savepath.ps1", | ||
| r#" | ||
| $Item = Get-Item -Path "HKCU:\Environment" |
| // checking path... | ||
| // Make a test.ps1 script that runs `where.exe {bin_name}` | ||
| // | ||
| // (note that "where" and "where.exe" are completely different things...) |
mistydemeo
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.