order platforms alphabetically

[ashleygwilliams]

[Plecra]

Hiya :) Going to have a look at this

[Plecra]

Aria poked around this a couple weeks back, and I think they saw the same sorted list of platforms I do on main:

oranda/src/site/artifacts/mod.rs

Lines 16 to 20 in 13505ef

	/// A map from TargetTriples to Installers that support that platform
	///
	/// In theory this should be BTreeMap or IndexMap but something in the pipeline from here to
	/// jinja seems to be forcing a sorting so it's deterministic..? Can't find docs for this.
	type Platforms = HashMap<TargetTriple, Vec<InstallerIdx>>;

I'll see if I can confirm where this is being sorted, and check we're not just getting lucky hashes ;D

[shadows-withal]

this PR #542 should guarantee that anything ordered passed into minijinja stays sorted, so hopefully that should help

[Plecra]

Hm, I think that may not work alone :) I just found the same code and I think the BTreeMap representation was actually saving us? The HashMap repr of platforms_with_downloads: Platforms might shuffle the platforms, and the BTreeMap was sorting them correctly. Using an IndexMap (which might happen if another crate enabled the preserve_order feature in the dependency tree) will maintain the incorrect sort produced by the HashMap.

[Plecra]

Oh even then we were getting lucky that the target triples had the same sort order as the display names! Adding a post process filter in the template is likely the easiest solution: https://docs.rs/minijinja/latest/minijinja/filters/fn.sort.html

I can PR that if you like?

[shadows-withal]

that sounds good, go for it!