Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display the available platforms alphabetically #544

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

Plecra
Copy link
Contributor

@Plecra Plecra commented Jul 26, 2023

the main change is on line 77 of artifacts_header.html.j2, which is supported by refactoring the template context into a list that contains the display names we want to sort by. I've removed the filter as we don't need to generate display names within the template anymore.

closes #480

the main change is on line 77 of artifacts_header.html.j2,
which is supported by refactoring the template context
into a list that contains the display names we
want to sort by
Copy link
Contributor

@shadows-withal shadows-withal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The tabs don't function at the moment because there's a non-renamed variable, but I've pointed it out.

templates/includes/artifacts_header.html.j2 Outdated Show resolved Hide resolved
templates/includes/artifacts_header.html.j2 Outdated Show resolved Hide resolved
@shadows-withal
Copy link
Contributor

Oh, also not sure if you're in there already, but if you're interested in keeping up-to-date with oranda, you can join the #oranda channel on our Discord: https://discord.gg/ta8wv4kUkS

@shadows-withal shadows-withal merged commit 6108cbe into axodotdev:main Jul 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

order platforms alphabetically
2 participants