Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo CSS class has disappeared #582

Closed
tertsdiepraam opened this issue Aug 12, 2023 · 2 comments · Fixed by #585
Closed

Logo CSS class has disappeared #582

tertsdiepraam opened this issue Aug 12, 2023 · 2 comments · Fixed by #585
Labels
bug - build priority - high someone from axo is working on this now regression
Milestone

Comments

@tertsdiepraam
Copy link

Hi! It's the guy who cares about the logo position again :)

In oranda 0.1, I could style the logo manually (e.g. scale it) with the .logo class, which was very convenient. However, in oranda 0.2, that CSS class has disappeared due to this PR: #526.

Before that PR, the logo was generated like this:

Ok(html!(<img src=src alt=name class="logo" />))

and afterwards like this:

<img src="{{ layout.logo }}" alt="{{ layout.project_name }}" />

As a result, these CSS rules also no longer apply:

.logo {
@apply m-auto block max-w-xs;
}

And thus the logo is no longer centered again.

@shadows-withal
Copy link
Contributor

Sorry about that! I knew there'd be some stuff that would slip through with that refactor, apologies. I will fix this and include it in next week's release.

@tertsdiepraam
Copy link
Author

No worries! I'm looking forward to the release!

@shadows-withal shadows-withal added the priority - high someone from axo is working on this now label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug - build priority - high someone from axo is working on this now regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants