Refactor into using minijinja templates instead of axohtml
#526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadows-withal
force-pushed
the
templating
branch
from
559d84c
to
c4c4e36
Compare
shadows-withal
changed the title
minijinja templates instead of axohtml
shadows-withal
force-pushed
the
templating
branch
from
c4c4e36
to
1fcc167
Compare
Gankra
approved these changes
Jul 13, 2023
|
Pushed up some resolutions of most of my comments. I ended up doing a quick pass over all the I added a couple TODOs for genuine questions I don't want to unilaterally make a call on, that should be resolved before merging. |
Gankra
requested changes
Jul 13, 2023
Comment on lines
+19
to
+23
| /// A map from TargetTriples to Installers that support that platform | ||
| /// | ||
| /// In theory this should be BTreeMap or IndexMap but something in the pipeline from here to | ||
| /// jinja seems to be forcing a sorting so it's deterministic..? Can't find docs for this. | ||
| type Platforms = HashMap<TargetTriple, Vec<InstallerIdx>>; |
Also flattens the DownloableFiles type to make it cleaner
Gankra
approved these changes
Jul 14, 2023
ashleygwilliams
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the code to use minijinja instead of axohtml.