feat: use tailwind binary to build CSS #565
Conversation
shadows-withal
force-pushed
the
feat/drop-yarn
branch
from
b1c9685
to
2cf70a1
Compare
|
The hero we needed |
shadows-withal
force-pushed
the
feat/drop-yarn
branch
from
2cf70a1
to
bd151a9
Compare
| @@ -52,7 +52,6 @@ module.exports = { | |||
| plugins: [ | |||
| require("@tailwindcss/typography"), | |||
| require("@tailwindcss/forms"), | |||
| require("@tailwindcss/line-clamp"), | |||
There was a problem hiding this comment.
(this is a default plugin in tailwind now)
| pub fn place_css(dist_dir: &str, release_tag: &str) -> Result<()> { | ||
| // Even if you're running a development build, we still respect the custom CSS version preference | ||
| // by falling back to fetching said version from GitHub. | ||
| if cfg!(debug_assertions) && release_tag == ORANDA_CSS_TAG { |
There was a problem hiding this comment.
to my knowledge there isn't a better way to find out whether we're running a dev build or a release build, right?
There was a problem hiding this comment.
It's either this or cfg(test) (neither of which would work for my habit of developing with --release). This is fine enough.
| "https://github.com/tailwindlabs/tailwindcss/releases/latest/download/tailwindcss-{double}" | ||
| ); | ||
| let handle = tokio::runtime::Handle::current(); | ||
| let response = handle.block_on(reqwest::get(url))?; |
There was a problem hiding this comment.
FYI: axoasset currently doesn't handle requests for a binary correctly, so for now I'm falling back to using reqwest (which is already in our dependency tree)
There was a problem hiding this comment.
Oh because it insists everything is utf8 text?
There was a problem hiding this comment.
no, because it does very naive mime type checking which basically only accounts for images, so it gets fussy and quits
shadows-withal
force-pushed
the
feat/drop-yarn
branch
from
9435b7c
to
3fe0459
Compare
| ("windows", "aarch64") => "windows-arm64.exe", | ||
| _ => "linux-x64", | ||
| }; | ||
| let mut binary_path = Utf8PathBuf::from(cache_dir.display().to_string()); |
There was a problem hiding this comment.
| let mut binary_path = Utf8PathBuf::from(cache_dir.display().to_string()); | |
| let mut binary_path = Utf8PathBuf::from_path(cache_dir)?; |
There was a problem hiding this comment.
doesn't work, Utf8PathBuf only has from_path_buf, which is annoyingly a side-effectful operation
There was a problem hiding this comment.
(Utf8Path has from_path, but we need an owned path)
Removes the dependency on a Node toolchain + Yarn to build CSS, as long as you're not running a release build. If you're running a release build, nothing changes, we still fetch the associated (or custom) CSS version from GitHub.
Also adds a new hidden command to generate just the CSS for the purposes of attaching it to a release, and modifies the corresponding workflow.