Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: inline css on release #566

Merged
merged 6 commits into from
Aug 3, 2023
Merged

feat: inline css on release #566

merged 6 commits into from
Aug 3, 2023

Conversation

shadows-withal
Copy link
Contributor

Closes #554. On release, this will pre-build the CSS and drop it into oranda-css/dist/oranda.css, as well as set an environment variable letting oranda know that it can inline that version.

Copy link
Member

@Gankra Gankra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect this won't work when you try to cargo-publish (hopefully --dry-run will complain appropriately)

Cargo.toml Outdated Show resolved Hide resolved
build.rs Outdated Show resolved Hide resolved
src/site/layout/css.rs Show resolved Hide resolved
Copy link
Member

@Gankra Gankra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the right approach, some fixes suggested.

src/commands/print.rs Outdated Show resolved Hide resolved
src/errors.rs Outdated Show resolved Hide resolved
src/site/layout/css.rs Outdated Show resolved Hide resolved
generate-css/src/lib.rs Outdated Show resolved Hide resolved
.github/workflows/publish-release.yml Outdated Show resolved Hide resolved
@shadows-withal shadows-withal merged commit 5d9e8b8 into main Aug 3, 2023
7 checks passed
@shadows-withal shadows-withal deleted the feat/inline-css branch August 3, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve CSS loading
2 participants