-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gallery demo #575
Gallery demo #575
Conversation
all the issues with oranda-gallery are fixed, but i realized a new one: snapshotting is fundamentally brittle to the fact that we source Github Releases for data, so any new Github Releases will change several pages and cause the tests to fail (and having oranda-itself in the gallery means cutting an oranda release will break oranda's own tests... rip) Possible solutions:
EDIT: implemented the 3rd one with DEBUG_DATA_CLAMP_DATE |
also a note on commit naming here:
|
Seems like a few system-specific slashes are making it into some actual html 😬:
|
in mdbook output files, so this seems like a mdbook bug more than anything, we don't do any weird linking or anything afaik |
stopped mdbook html files from being output into snapshots, we don't want them there anyways, that's for mdbook itself to test |
b1fb9dc
to
df85452
Compare
b2a0b05
to
f018ebe
Compare
How to build the gallery:
How to serve the gallery:
select
is always sorted but the actual entries the select reveals aren't)cargo test
andcargo test --release
write different file names)cargo test
work without--release
(need to make the runtime generate-css function remember where CARGO_MANIFEST_DIR is instead of just going relative to cwd, so that the resulting binary can be run in different dirs on the same system)oranda-workspace.json
(cargo-dist can happily edit the same checkout over and over, but oranda-workspace wants each variant to exist at the same time, so I'll probably just add a variant ofrun_test
that takes a custom id (checkout dir name) so that you can checkout the same repo multiple times)