Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: relax file requirements, improve IO errors #640

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

shadows-withal
Copy link
Contributor

@shadows-withal shadows-withal commented Sep 29, 2023

Behaviour changes:

  • Readme file doesn't need to exist anymore, is now optional, with a warning being output
  • oranda now hard errors when a hardcoded mdbook path can't be found
  • local logo paths will now error when they're not found
  • additional pages paths will also error when they're not found

TODO:

  • Add backticks around the path in the error message for readability
  • Update docs to mention that you don't need a readme circa 0.5.0

@shadows-withal
Copy link
Contributor Author

Screenshots:

@shadows-withal shadows-withal added this to the oranda-0.5.0 milestone Sep 29, 2023
src/errors.rs Outdated Show resolved Hide resolved
@shadows-withal shadows-withal merged commit 73946dc into main Sep 29, 2023
7 checks passed
@shadows-withal shadows-withal deleted the fix/path-fallback branch September 29, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants