Refactor code / fix bugs / add exception handling / move import cover…

…age button to the report tab if the test solution can be loaded / make it possible to generate HTML report from imported coverage reports
axodox · Jul 1, 2018 · 18eef76 · 18eef76
1 parent 8fa4a43
commit 18eef76
Show file tree

Hide file tree

Showing 11 changed files with 106 additions and 38 deletions.
diff --git a/AxoCover/Models/Testing/Results/CoverageProvider.cs b/AxoCover/Models/Testing/Results/CoverageProvider.cs
@@ -30,6 +30,8 @@ public class CoverageProvider : ICoverageProvider
     private static readonly Regex _methodNameRegex = new Regex("^(?<returnType>[^ ]*) [^:]*::(?<methodName>[^\\(]*)\\((?<argumentList>[^\\)]*)\\)$", RegexOptions.Compiled);
     private readonly Regex _visitorNameRegex = new Regex("^[^ ]* (?<visitorName>[^:]*::[^\\(]*)\\([^\\)]*\\)$", RegexOptions.Compiled);
 
+    public string ReportPath => _report?.FilePath;
+
     public CoverageProvider(ITestProvider testProvider, ITestRunner testRunner, ITelemetryManager telemetryManager, IEditorContext editorContext)
     {
       _testRunner = testRunner;
@@ -40,10 +42,18 @@ public CoverageProvider(ITestProvider testProvider, ITestRunner testRunner, ITel
       _editorContext.SolutionClosing += OnSolutionClosing;
     }
 
-    public void OpenCoverageReport(string reportPath)
+    public bool TryOpenCoverageReport(string reportPath)
     {
-      _report = GenericExtensions.ParseXml<CoverageSession>(reportPath);
-      CoverageUpdated?.Invoke(this, EventArgs.Empty);
+      try
+      {
+        _report = GenericExtensions.ParseXml<CoverageSession>(reportPath);
+        CoverageUpdated?.Invoke(this, EventArgs.Empty);
+        return true;
+      }
+      catch
+      {
+        return false;
+      }
     }
 
     private void OnSolutionClosing(object sender, EventArgs e)

diff --git a/AxoCover/Models/Testing/Results/ICoverageProvider.cs b/AxoCover/Models/Testing/Results/ICoverageProvider.cs
@@ -8,7 +8,9 @@ public interface ICoverageProvider
   {
     event EventHandler CoverageUpdated;
 
-    void OpenCoverageReport(string reportPath);
+    bool TryOpenCoverageReport(string reportPath);
+
+    string ReportPath { get; }
 
     Task<FileCoverage> GetFileCoverageAsync(string filePath);
 

diff --git a/AxoCover/Resources.Designer.cs b/AxoCover/Resources.Designer.cs
diff --git a/AxoCover/Resources.resx b/AxoCover/Resources.resx
@@ -661,9 +661,15 @@
     <value>Test anchors</value>
   </data>
   <data name="OpenCoverageReport" xml:space="preserve">
-    <value>Open report</value>
+    <value>Open external report</value>
   </data>
   <data name="OpenCoverageReportFilter" xml:space="preserve">
-    <value>Coverage reports (*.xml)|*.xml|All files (*.*)|*.*</value>
+    <value>OpenCover coverage reports (*.xml)|*.xml|All files (*.*)|*.*</value>
+  </data>
+  <data name="OpenReport" xml:space="preserve">
+    <value>Import</value>
+  </data>
+  <data name="OpenCoverageFailed" xml:space="preserve">
+    <value>Cannot import OpenCover coverage file {0}.</value>
   </data>
 </root>
diff --git a/AxoCover/ViewModels/CoverageExplorerViewModel.cs b/AxoCover/ViewModels/CoverageExplorerViewModel.cs
@@ -6,6 +6,7 @@
 using AxoCover.Models.Testing.Results;
 using AxoCover.Views;
 using System;
+using System.Windows;
 using System.Windows.Input;
 
 namespace AxoCover.ViewModels
@@ -91,6 +92,14 @@ public ICommand CollapseAllCommand
       }
     }
 
+    public ICommand OpenReportCommand
+    {
+      get
+      {
+        return new DelegateCommand(p => OpenCoverageReport());
+      }
+    }
+
     public ICommand GenerateReportCommand
     {
       get
@@ -170,8 +179,27 @@ private void Update(CoverageItem resultSolution)
 
     private async void OnCoverageUpdated(object sender, EventArgs e)
     {
+      ReportPath = _coverageProvider.ReportPath;
       var resultSolution = await _coverageProvider.GetCoverageAsync();
       Update(resultSolution);
     }
+
+    private void OpenCoverageReport()
+    {
+      var openFileDialog = new Microsoft.Win32.OpenFileDialog
+      {
+        Title = Resources.OpenCoverageReport,
+        Filter = Resources.OpenCoverageReportFilter,
+        CheckFileExists = true
+      };
+
+      if (openFileDialog.ShowDialog() == true)
+      {
+        if(!_coverageProvider.TryOpenCoverageReport(openFileDialog.FileName))
+        {
+          MessageBox.Show(string.Format(Resources.OpenCoverageFailed, openFileDialog.FileName), Resources.OpenCoverageReport, MessageBoxButton.OK, MessageBoxImage.Error);
+        }
+      }
+    }
   }
 }
diff --git a/AxoCover/ViewModels/TestExplorerViewModel.cs b/AxoCover/ViewModels/TestExplorerViewModel.cs
@@ -13,6 +13,7 @@
 using System.ComponentModel;
 using System.Linq;
 using System.Threading.Tasks;
+using System.Windows;
 using System.Windows.Input;
 
 namespace AxoCover.ViewModels
@@ -297,7 +298,7 @@ public ICommand OpenCoverageReportCommand
     {
       get
       {
-        return new DelegateCommand(OpenCoverageReport);
+        return new DelegateCommand(p => OpenCoverageReport());
       }
     }
 
@@ -430,14 +431,27 @@ private async void OnOptionChanged(object sender, PropertyChangedEventArgs e)
 
     bool _suppressAutoLoadAndRun = false;
 
-    private async void OpenCoverageReport(object parameter)
+    private void OpenCoverageReport()
     {
-      if (parameter == null) return ;
+      var openFileDialog = new Microsoft.Win32.OpenFileDialog
+      {
+        Title = Resources.OpenCoverageReport,
+        Filter = Resources.OpenCoverageReportFilter,
+        CheckFileExists = true
+      };
 
-      _coverageProvider.OpenCoverageReport((string)parameter);
-      IsReportAvailable = true;
-      SetStateToReady();
-      IsReportTabSelected = true;
+      if (openFileDialog.ShowDialog() == true)
+      {
+        if(_coverageProvider.TryOpenCoverageReport(openFileDialog.FileName))
+        {
+          IsReportAvailable = true;
+          IsReportTabSelected = true;
+        }
+        else
+        {
+          MessageBox.Show(string.Format(Resources.OpenCoverageFailed, openFileDialog.FileName), Resources.OpenCoverageReport, MessageBoxButton.OK, MessageBoxImage.Error);
+        }
+      }
     }
 
     private async void RunTestItem(TestItemViewModel target, bool isCovering, bool isDebugging, bool isCoverAfterBuild = false)

diff --git a/AxoCover/Views/CoverageExplorerView.xaml b/AxoCover/Views/CoverageExplorerView.xaml
@@ -105,6 +105,10 @@
 
     <DockPanel Visibility="{Binding ResultSolution, Converter={StaticResource NullToVisibilityConverter}}">
       <UniformGrid Rows="1" DockPanel.Dock="Top">
+        <controls:ActionButton Text="{x:Static res:Resources.OpenReport}"
+                               Icon="/AxoCover;component/Resources/open.png"
+                               Command="{Binding OpenReportCommand}"/>
+
         <controls:ActionButton Text="{x:Static res:Resources.GenerateReport}"
                                Icon="/AxoCover;component/Resources/export.png"
                                Command="{Binding GenerateReportCommand}"/>

diff --git a/AxoCover/Views/TestExplorerView.xaml b/AxoCover/Views/TestExplorerView.xaml
@@ -229,11 +229,6 @@
                                              Icon="/AxoCover;component/Resources/collapse.png"
                                              Command="{Binding CollapseAllCommand}"
                                              Visibility="{Binding IsFiltering, Source={x:Reference _searchBox}, Converter={StaticResource InvertedBooleanToVisibilityConverter}}"/>
-                      <controls:ActionButton Text="{x:Static res:Resources.OpenCoverageReport}"
-                                             Icon="/AxoCover;component/Resources/open.png"
-                                             Command="{Binding OpenCoverageReportCommand}"
-                                             CommandParameter="{Binding Tag, RelativeSource={RelativeSource Self}}"
-                                             Click="OnOpenCoverageReportClick"/>
                     </UniformGrid>
 
                     <controls:SearchBox DockPanel.Dock="Top" x:Name="_searchBox"
@@ -280,13 +275,10 @@
                               Visibility="{Binding TestSolution.IsEmpty, Converter={StaticResource BooleanToVisibilityConverter}}">
                     <TextBlock Text="{x:Static res:Resources.TestExplorerPlaceholder}"
                                TextWrapping="Wrap" Margin="12" HorizontalAlignment="Center" TextAlignment="Center"/>
-                    <StackPanel Margin="12">
-                      <controls:ActionButton Text="{x:Static res:Resources.OpenCoverageReport}"
-                                             Icon="/AxoCover;component/Resources/open.png"
-                                             Command="{Binding OpenCoverageReportCommand}"
-                                             CommandParameter="{Binding Tag, RelativeSource={RelativeSource Self}}"
-                                             Click="OnOpenCoverageReportClick"/>
-                    </StackPanel>
+                    <controls:ActionButton Text="{x:Static res:Resources.OpenCoverageReport}"
+                                           Icon="/AxoCover;component/Resources/open.png"
+                                           Command="{Binding OpenCoverageReportCommand}"
+                                           Margin="12" HorizontalAlignment="Center"/>
                     <StackPanel Margin="12">
                       <TextBlock HorizontalAlignment="Center" TextWrapping="Wrap" Text="{x:Static res:Resources.SupportedTestFrameworks}" Margin="3"/>
                       <WrapPanel HorizontalAlignment="Center">

diff --git a/AxoCover/Views/TestExplorerView.xaml.cs b/AxoCover/Views/TestExplorerView.xaml.cs
@@ -61,14 +61,5 @@ private void OnListTestItemMouseDown(object sender, MouseButtonEventArgs e)
         e.Handled = true;
       }
     }
-
-    private void OnOpenCoverageReportClick(object sender, RoutedEventArgs e)
-    {
-      var ofd = new Microsoft.Win32.OpenFileDialog();
-      ofd.Filter = AxoCover.Resources.OpenCoverageReportFilter;
-      ofd.CheckFileExists = true;
-
-      ((FrameworkElement)sender).Tag = ofd.ShowDialog() == true ? ofd.FileName : null;
-    }
   }
 }
diff --git a/AxoCover/changelog.txt b/AxoCover/changelog.txt
@@ -1,4 +1,7 @@
-1.1.7
+1.1.8
+- Added ability to import externally generated OpenCover reports (thanks Anton Tykhyy)
+
+1.1.7
 - Coverage visualization is now tracking file changes
 - Added test anchors for quick test access
 - Provide PDB search paths to OpenCover

diff --git a/AxoCover/source.extension.vsixmanifest b/AxoCover/source.extension.vsixmanifest
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
   <Metadata>
-    <Identity Id="26901782-38e1-48d4-94e9-557d44db052e" Version="1.1.6.14" Language="en-US" Publisher="Péter Major" />
+    <Identity Id="26901782-38e1-48d4-94e9-557d44db052e" Version="1.1.7.0" Language="en-US" Publisher="Péter Major" />
     <DisplayName>AxoCover</DisplayName>
     <Description xml:space="preserve">Nice and free .Net code coverage support for Visual Studio with OpenCover.</Description>
     <MoreInfo>https://marketplace.visualstudio.com/items?itemName=axodox1.AxoCover</MoreInfo>