Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch onnxissue 1.16.0 issue #758

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Patch onnxissue 1.16.0 issue #758

merged 2 commits into from
Sep 26, 2023

Conversation

mathieuboudreau
Copy link
Member

@mathieuboudreau mathieuboudreau commented Sep 25, 2023

Checklist

  • I've given this PR a concise, self-descriptive, and meaningful title
  • I've linked relevant issues in the PR body
  • I've applied the relevant labels to this PR
  • I've added relevant tests for my contribution
  • I've updated the documentation and/or added correct docstrings
  • I've assigned a reviewer
  • I've consulted ADS's internal developer documentation to ensure my contribution is in line with any relevant design decisions

Description

Recently failed build: https://github.com/axondeepseg/axondeepseg/actions/runs/6292225299/job/17081415695#step:8:1282

Error message:

FAILED test/test_integrity_test.py::TestCore::test_integrity_test_script_runs_successfully - ValueError: This ORT build has ['AzureExecutionProvider', 'CPUExecutionProvider'] enabled. Since ORT 1.9, you are required to explicitly set the providers parameter when instantiating InferenceSession. For example, onnxruntime.InferenceSession(..., providers=['AzureExecutionProvider', 'CPUExecutionProvider'], ...)

Issue opened by other people that dependency's repo: microsoft/onnxruntime#17631

Linked issues

#757

@mathieuboudreau mathieuboudreau marked this pull request as draft September 25, 2023 18:24
@mathieuboudreau mathieuboudreau added the dependencies Pull requests that update a dependency file label Sep 25, 2023
@mathieuboudreau mathieuboudreau marked this pull request as ready for review September 25, 2023 20:25
@@ -6,7 +6,7 @@ dependencies:
- scipy
- scikit-learn=1.1.1
- scikit-image=0.19.3
- tabulate
- tabulate<
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the < do?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo, will fix in another PR

Copy link
Member

@Stoyan-I-A Stoyan-I-A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve this since otherwise the segmentation will simply not run. But we should check if the issue is resolved in the future.
Another option would be to explicitly set the appropriate execution provider in Ivadomed.

@Stoyan-I-A Stoyan-I-A merged commit d68e328 into master Sep 26, 2023
5 checks passed
@mathieuboudreau mathieuboudreau deleted the mb/onnxissue branch March 11, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants