Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update product readme #30

Merged
merged 2 commits into from Apr 11, 2024
Merged

Update product readme #30

merged 2 commits into from Apr 11, 2024

Conversation

tutn-axonivy
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Apr 11, 2024

Test Results

5 tests  ±0   5 ✅ ±0   13s ⏱️ ±0s
2 suites ±0   0 💤 ±0 
2 files   ±0   0 ❌ ±0 

Results for commit fe793a8. ± Comparison against base commit 840db99.

♻️ This comment has been updated with latest results.

@@ -7,25 +7,6 @@ The Adobe Acrobat Sign Connector is a project that simplifies the authentication

An Adobe Sign account needs to be created to setup and use the connector.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this sentence should be the first one after ## Adobe Sign account creation

e. Developer account is created
![account-finished](images/createAccountFinished.png)


Adobe Sign provides 2 options for authentication. (See Setup section)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this part ... until #Admin Setup Page ... is also somewhat asorted and doesn't help me. I think it should be under an own header? 🤔 ... but I can't find a good name.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also ok for me to leave it as is, maybe @ivy-sgi or one of the original developers should re-work the full setup description 🤷

@tutn-axonivy tutn-axonivy merged commit fa79fad into master Apr 11, 2024
4 checks passed
@tutn-axonivy tutn-axonivy deleted the update-product-readme branch April 11, 2024 09:30
@ivy-rew
Copy link
Member

ivy-rew commented Apr 11, 2024

thanks a lot @tutn-axonivy

@tutn-axonivy
Copy link
Contributor Author

Hi @ivy-rew, do we need to run the Release script?

@ivy-rew
Copy link
Member

ivy-rew commented Apr 11, 2024

Hi @ivy-rew, do we need to run the Release script?

yes, changed product descriptions always require a new release.

@ivy-sgi
Copy link
Member

ivy-sgi commented Apr 15, 2024

Hi @tutn-axonivy ! As Andreas and me are currently revising the documentation for each connector, we will also touch this one and bundle them all for one release. So I would say nothing do be done from your side - I will consider it for a future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants