Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XIVY-13138 Change inscription lsp connection #456

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

ivy-lli
Copy link
Member

@ivy-lli ivy-lli commented Jan 9, 2024

  • Remove unused toolbar button
  • Move inscription actions to ui package
  • Change inscription activate action
  • Cleanup code a bit

- Remove unused toolbar button
- Move inscription actions to ui package
- Change inscription activate action
- Cleanup code a bit
@ivy-lli ivy-lli requested a review from ivy-lmu January 9, 2024 06:54
@ivy-lli ivy-lli merged commit eb3a64b into master Jan 9, 2024
6 checks passed
@ivy-lli ivy-lli deleted the lsp-connection branch January 9, 2024 06:54
@ivy-lli
Copy link
Member Author

ivy-lli commented Jan 9, 2024

not the fix, that we can connect without a direct websocket connection, but a necessary change based on the change of axonivy/inscription-client#474

Copy link
Member

@ivy-lmu ivy-lmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants