Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pimp integrations #489

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Pimp integrations #489

merged 1 commit into from
Feb 19, 2024

Conversation

ivy-lli
Copy link
Member

@ivy-lli ivy-lli commented Feb 19, 2024

  • Fix eclipse integration styles (glsp css need to be loaded befor ours)
  • Dispatch ui extensions before model request (new UpdatePaletteItems action was needed, because those still needs to be loaded after the model request is sent)

- Fix eclipse integration styles (glsp css need to be loaded befor ours)
- Dispatch ui extensions before model request (new UpdatePaletteItems action was needed, because those still needs to be loaded after the model request is sent)
@ivy-lli ivy-lli requested a review from ivy-cst February 19, 2024 14:03
@ivy-lli
Copy link
Member Author

ivy-lli commented Feb 19, 2024

Screen Recording 2024-02-19 at 15 13 44

Copy link
Member

@ivy-cst ivy-cst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks very much 👍

@ivy-cst
Copy link
Member

ivy-cst commented Feb 19, 2024

Was already a lot better without the loading messages...

@ivy-lli ivy-lli merged commit 4ca0cfc into master Feb 19, 2024
6 checks passed
@ivy-lli ivy-lli deleted the pimp-integrations branch February 19, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants