Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix several bugs about interoperability signature verification #1105

Merged
merged 15 commits into from
Apr 4, 2023
Merged

fix: fix several bugs about interoperability signature verification #1105

merged 15 commits into from
Apr 4, 2023

Conversation

KaoImin
Copy link
Contributor

@KaoImin KaoImin commented Mar 21, 2023 •
edited
Loading

What this PR does / why we need it:

This PR

Which issue(s) this PR fixes:

Fixes #

Which docs this PR relation:

Ref #

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

NIL

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Chaos CI
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

@KaoImin KaoImin force-pushed the joyid-debug branch 2 times, most recently from 65721b9 to 5cd766e Compare March 31, 2023 09:28
@KaoImin KaoImin changed the title [WIP] fix: classify interoperation signature fix: fix several bugs about interoperability signature verification Mar 31, 2023
@KaoImin KaoImin marked this pull request as ready for review March 31, 2023 11:23
@KaoImin KaoImin requested a review from a team as a code owner March 31, 2023 11:23
@KaoImin
Copy link
Contributor Author

KaoImin commented Mar 31, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Mar 31, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin KaoImin requested review from wenyuanhust and removed request for ahonn March 31, 2023 11:24
@KaoImin
Copy link
Contributor Author

KaoImin commented Apr 1, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Apr 1, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin
Copy link
Contributor Author

KaoImin commented Apr 3, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Apr 3, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin
Copy link
Contributor Author

KaoImin commented Apr 4, 2023

/run-ci

1 similar comment
@KaoImin
Copy link
Contributor Author

KaoImin commented Apr 4, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Apr 4, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

1 similar comment
@axon-bot
Copy link

axon-bot bot commented Apr 4, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin KaoImin added this pull request to the merge queue Apr 4, 2023
Merged via the queue into main with commit b1e0476 Apr 4, 2023
@wenyuanhust wenyuanhust mentioned this pull request Apr 8, 2023
Closed
@KaoImin KaoImin deleted the joyid-debug branch April 10, 2023 01:45
@KaoImin KaoImin restored the joyid-debug branch April 19, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driftluo driftluo driftluo approved these changes

@peterzhb peterzhb Awaiting requested review from peterzhb peterzhb is a code owner automatically assigned from axonweb3/axon-dev

@wenyuanhust wenyuanhust Awaiting requested review from wenyuanhust

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KaoImin @driftluo