Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sync): fix return early in synchronization #1264

Merged
merged 2 commits into from Jul 7, 2023
Merged

fix(sync): fix return early in synchronization #1264

merged 2 commits into from Jul 7, 2023

Conversation

KaoImin
Copy link
Contributor

@KaoImin KaoImin commented Jul 6, 2023

What this PR does / why we need it:

This PR fix a bug that sync should update the cache status when early return from a synchronization process.

Which issue(s) this PR fixes:

Fixes #

Which docs this PR relation:

Ref #

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

NIL

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Chaos CI
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

@KaoImin KaoImin requested a review from a team as a code owner July 6, 2023 07:08
@github-actions github-actions bot added the bugfix label Jul 6, 2023
@KaoImin
Copy link
Contributor Author

KaoImin commented Jul 6, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Jul 6, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • Chaos CI
  • E2E Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin
Copy link
Contributor Author

KaoImin commented Jul 6, 2023

/run-ci

@KaoImin KaoImin requested review from blckngm and driftluo and removed request for jjyr July 6, 2023 10:11
@axon-bot
Copy link

axon-bot bot commented Jul 6, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • Chaos CI
  • E2E Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin KaoImin added this pull request to the merge queue Jul 7, 2023
Merged via the queue into main with commit 0655b3d Jul 7, 2023
24 checks passed
@KaoImin KaoImin deleted the fix-sync branch July 7, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants