Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: reduce mem cost on modexp #1300

Merged
merged 1 commit into from Aug 4, 2023
Merged

perf: reduce mem cost on modexp #1300

merged 1 commit into from Aug 4, 2023

Conversation

driftluo
Copy link
Contributor

@driftluo driftluo commented Aug 3, 2023

What this PR does / why we need it:

This PR reduces mem cost on modexp. Compute gas cost using independent resolution scheme

Which issue(s) this PR fixes:

Fixes #

Which docs this PR relation:

Ref #

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

NIL

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Chaos CI
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

@driftluo driftluo requested a review from a team as a code owner August 3, 2023 07:46
@github-actions github-actions bot added the enhancement New feature or request label Aug 3, 2023
@Flouse Flouse requested review from KaoImin and removed request for Simon-Tl August 3, 2023 10:52
@KaoImin
Copy link
Contributor

KaoImin commented Aug 3, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Aug 3, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy

Please check ci test results later.

@driftluo driftluo force-pushed the reduce-mem-use-on-mod-exp branch 3 times, most recently from 79bee21 to bca7d33 Compare August 4, 2023 07:26
@KaoImin KaoImin added this pull request to the merge queue Aug 4, 2023
Merged via the queue into main with commit bc7149f Aug 4, 2023
19 checks passed
@driftluo driftluo deleted the reduce-mem-use-on-mod-exp branch August 4, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants