feature: add rpc client #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterzhb
force-pushed
the
@peter/add-rpc-client
branch
from
7b7654a
to
6c7f05e
Compare
peterzhb
force-pushed
the
@peter/add-rpc-client
branch
from
6c7f05e
to
d4d6a5c
Compare
|
Why not directly rely on emitter-lib, but choose to copy the code？ |
The call to the server doesn't need to be a rpc call or socket subscription since now rpc is inside the spark. Also it doesn't need the header sync. So far it only needs to sync the metadata cell data actually. So the functionalities and code size are less. Actually I can further reduce the serialization and persistence to be just a dict of searchkey and block number. |
peterzhb
force-pushed
the
@peter/add-rpc-client
branch
3 times, most recently
from
c6f3f64
to
15281e2
Compare
peterzhb
force-pushed
the
@peter/add-rpc-client
branch
from
15281e2
to
6ce39be
Compare
felicityin
reviewed
May 17, 2023
peterzhb
force-pushed
the
@peter/add-rpc-client
branch
from
6ce39be
to
3459b40
Compare
KaoImin
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds both the axon client which handles communication with axon and the ckb client which handles rpc requests to ckb_indexer.
The axon client is not fully finished. The endpoint to send the metadata to axon is left unimplemented so far.