Support Windows Store / UWP Paths #2041
Merged
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is a case I should have considered before-- thanks for the PR. I'll probably change a couple things, but great work for your first go at C++ 👍 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Repository owner
locked as resolved and limited conversation to collaborators
Nov 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have never worked on a C++ application before. There are probably some improvements that could be made with how this is handled.
At the moment, Windows Store / UWP is not properly handled. Unlike the desktop app, UWP stores files in an admin-only, read-only directory while the settings are stored elsewhere. Changing the
version_folderfor the Windows Store version allows the file to be written and take effect.