refactoring

axypro · Jun 20, 2016 · 9bc3398 · 9bc3398
1 parent b8fb317
commit 9bc3398
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/StreamTest.php b/StreamTest.php
@@ -39,10 +39,6 @@ public function readLine()
         }
 
         $lineList = preg_split("/(\\r\\n|\\r|\\n)/", $this->data, -1, PREG_SPLIT_DELIM_CAPTURE);
-        if (!isset($lineList[0])) {
-            return false;
-        }
-
         $result = $lineList[0];
 
         if (isset($lineList[1])) {

diff --git a/tests/StreamContainerTest.php b/tests/StreamContainerTest.php
@@ -33,4 +33,14 @@ public function testChangeField()
         $this->setExpectedException('axy\errors\FieldNotExist');
         $this->assertInstanceOf('axy\env\StreamTest', $streamContainer->notExist);
     }
+
+    public function testBadStream()
+    {
+        $stream = new \stdClass();
+
+        $this->setExpectedException('axy\errors\NotValid');
+        new StreamContainer([
+            'stdin' => $stream,
+        ]);
+    }
 }