New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making I
, and Partial
a primitive
#489
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #489 +/- ##
============================================
- Coverage 81.37% 81.31% -0.07%
+ Complexity 2649 2644 -5
============================================
Files 234 234
Lines 8069 8085 +16
Branches 991 989 -2
============================================
+ Hits 6566 6574 +8
- Misses 964 979 +15
+ Partials 539 532 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ice1000
reviewed
Sep 11, 2022
… formula to face restriction to be done. added many tests
lunalunaa
force-pushed
the
partial-prim
branch
from
September 11, 2022 20:48
8e3ce40
to
75f212d
Compare
ice1000
reviewed
Sep 11, 2022
imkiva
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rua
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I
andPartial
are now a primitive instead of a keyword.What still needs to be done
Elaborate primitives atCallTerm.make
Edit (@ice1000): we no longer hack
CallTerm.make
, but we instead hackExprTycker::defCall
, and we eagerly reduce primCalls.In the future, we will ban functions that takes
Type
types intoISet
types, and we only allow pureISet
functions. Those functions will be marked as always-inline.