Cherry pick from @HoshinoTented's branch #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
that referenced
this pull request
Oct 29, 2022
617: Cherry pick from @HoshinoTented's branch r=ice1000 a=ice1000 Hoshino Tented bors r+ Co-authored-by: ice1000 <ice1000kotlin@foxmail.com>
|
Build failed:
|
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 29, 2022
617: Cherry pick from @HoshinoTented's branch r=ice1000 a=ice1000 Hoshino Tented We cannot solve metas in result type from clauses, because when we're in the clauses, the result type is substituted, and it doesn't make sense to solve a "substituted meta" In the future, we may generate a "constant" meta and try to solve it if the result type is a pure meta. Co-authored-by: ice1000 <ice1000kotlin@foxmail.com>
|
Canceled. |
|
bors r+ |
|
Build succeeded: |
Codecov Report
@@ Coverage Diff @@
## main #617 +/- ##
=========================================
Coverage 79.89% 79.90%
- Complexity 2796 2797 +1
=========================================
Files 228 228
Lines 8850 8852 +2
Branches 1097 1098 +1
=========================================
+ Hits 7071 7073 +2
Misses 1192 1192
Partials 587 587
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoshino Tented
We cannot solve metas in result type from clauses, because when we're in the clauses, the result type is substituted, and it doesn't make sense to solve a "substituted meta"
In the future, we may generate a "constant" meta and try to solve it if the result type is a pure meta.