Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massive rename planned long time ago #632

Merged
merged 12 commits into from
Nov 5, 2022
Merged

Massive rename planned long time ago #632

merged 12 commits into from
Nov 5, 2022

Conversation

ice1000
Copy link
Member

@ice1000 ice1000 commented Nov 5, 2022

Yeah we're bringing the flat structure back to Term.

Rationales

  • The core language is expected to have a lot of operations on it, so several core terms in one file is a bit crowded. We will add even more!
    • Some terms cannot be classified, so we're not actually classifying terms by having some stupid shared interfaces anyway. We should make individual interfaces for their own purposes.
    • All core nodes have the same naming pattern: [A-Z][a-z]*Term!
  • The concrete syntax disappears immediately after type checking, so they're going to be smol. I removed their name postfixes bc they're obvious.

@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Merging #632 (bf0820e) into main (6722eb4) will decrease coverage by 0.01%.
The diff coverage is 74.23%.

❗ Current head bf0820e differs from pull request most recent head 2c67240. Consider uploading reports for the commit 2c67240 to get more accurate results

@@             Coverage Diff              @@
##               main     #632      +/-   ##
============================================
- Coverage     79.14%   79.13%   -0.02%     
- Complexity     2763     2817      +54     
============================================
  Files           231      254      +23     
  Lines          9107     9106       -1     
  Branches       1114     1111       -3     
============================================
- Hits           7208     7206       -2     
- Misses         1290     1291       +1     
  Partials        609      609              
Impacted Files Coverage Δ
.../src/main/java/org/aya/concrete/stmt/TeleDecl.java 90.54% <ø> (ø)
...n/java/org/aya/concrete/visitor/ExprTraversal.java 0.00% <0.00%> (ø)
...main/java/org/aya/concrete/visitor/StmtFolder.java 0.00% <0.00%> (ø)
base/src/main/java/org/aya/core/def/CtorDef.java 78.94% <ø> (ø)
base/src/main/java/org/aya/core/def/FnDef.java 100.00% <ø> (ø)
...ase/src/main/java/org/aya/core/repr/CodeShape.java 44.44% <ø> (ø)
base/src/main/java/org/aya/core/term/FormTerm.java 71.42% <ø> (-10.11%) ⬇️
...ase/src/main/java/org/aya/core/term/HCompTerm.java 0.00% <0.00%> (ø)
base/src/main/java/org/aya/core/term/RefTerm.java 100.00% <ø> (ø)
...rc/main/java/org/aya/core/visitor/DefConsumer.java 38.46% <ø> (ø)
... and 127 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ice1000 ice1000 added this to the v0.23 milestone Nov 5, 2022
@ice1000
Copy link
Member Author

ice1000 commented Nov 5, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 5, 2022

Build succeeded:

@bors bors bot merged commit 49d8bd4 into main Nov 5, 2022
@bors bors bot deleted the rename branch November 5, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant