Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern -> Arg<Pattern> #642

Merged
merged 5 commits into from
Nov 8, 2022
Merged

Pattern -> Arg<Pattern> #642

merged 5 commits into from
Nov 8, 2022

Conversation

ice1000
Copy link
Member

@ice1000 ice1000 commented Nov 8, 2022

/cc @imkiva @HoshinoTented

The syntax of as patterns is changed. Now, you'll have to use (f a b as c) over (f a b) as c

@ice1000 ice1000 added this to the v0.23 milestone Nov 8, 2022
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #642 (e5726ef) into main (3d43ccb) will decrease coverage by 0.01%.
The diff coverage is 82.69%.

@@             Coverage Diff              @@
##               main     #642      +/-   ##
============================================
- Coverage     79.34%   79.33%   -0.02%     
+ Complexity     2831     2822       -9     
============================================
  Files           254      254              
  Lines          9186     9181       -5     
  Branches       1115     1117       +2     
============================================
- Hits           7289     7284       -5     
  Misses         1289     1289              
  Partials        608      608              
Impacted Files Coverage Δ
.../src/main/java/org/aya/concrete/stmt/TeleDecl.java 90.54% <ø> (ø)
...n/java/org/aya/concrete/visitor/ExprTraversal.java 0.00% <0.00%> (ø)
...main/java/org/aya/concrete/visitor/StmtFolder.java 0.00% <0.00%> (ø)
...rc/main/java/org/aya/concrete/visitor/StmtOps.java 0.00% <0.00%> (ø)
.../src/main/java/org/aya/core/repr/ShapeMatcher.java 68.85% <0.00%> (ø)
...ava/org/aya/concrete/desugar/BinPatternParser.java 52.17% <62.50%> (+2.17%) ⬆️
...ase/src/main/java/org/aya/core/repr/CodeShape.java 52.38% <62.50%> (ø)
base/src/main/java/org/aya/generic/Shaped.java 74.50% <83.33%> (+1.04%) ⬆️
...c/main/java/org/aya/distill/ConcreteDistiller.java 82.69% <87.50%> (-0.46%) ⬇️
...src/main/java/org/aya/cli/parse/AyaGKProducer.java 88.84% <97.56%> (-0.09%) ⬇️
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ice1000
Copy link
Member Author

ice1000 commented Nov 8, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 8, 2022

Build succeeded:

@bors bors bot merged commit 93d6648 into main Nov 8, 2022
@bors bors bot deleted the cigar branch November 8, 2022 06:30
@ice1000
Copy link
Member Author

ice1000 commented Nov 8, 2022

image

@ice1000 ice1000 linked an issue Nov 8, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use instead Arg<Pattern>
2 participants