Fix my opinions #693
Merged
Fix my opinions #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #693 +/- ##
============================================
+ Coverage 78.87% 78.90% +0.03%
- Complexity 2875 2884 +9
============================================
Files 260 261 +1
Lines 9471 9485 +14
Branches 1178 1179 +1
============================================
+ Hits 7470 7484 +14
+ Misses 1376 1371 -5
- Partials 625 630 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Closed
ice1000
previously approved these changes
Nov 18, 2022
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 18, 2022
693: Fix my opinions r=ice1000 a=imkiva - `Doc.renderXXX` now uses the default configuration for each "output target". - `RenderOptions.render()` now renders the `Doc` with configurable colors and styles. - Whenever outputting to a terminal, use `AdaptiveCli` (by default) or `UnixTermStylist` (if either color or style is changed), which is guaranteed now by `RenderOptions.stylist()` and `RenderOptions.defaultStylist()` - `AdaptiveCli` is now a standalone `Stylist` (instead of a `StyleFamily`) - `Stylist` can be viewed as the frozen `Sig CS ** SF ** OutputTarget`, while `RenderOptions` reads user-configured `CS` and `SF` and create the `Stylist` according to "output target". Co-authored-by: imkiva <imkiva@islovely.icu> Co-authored-by: ice1000 <ice1000kotlin@foxmail.com>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc.renderXXXnow uses the default configuration for each "output target".RenderOptions.render()now renders theDocwith configurable colors and styles.AdaptiveCli(by default) orUnixTermStylist(if either color or style is changed), which is guaranteed now byRenderOptions.stylist()andRenderOptions.defaultStylist()AdaptiveCliis now a standaloneStylist(instead of aStyleFamily)Stylistcan be viewed as the frozenSig CS ** SF ** OutputTarget, whileRenderOptionsreads user-configuredCSandSFand create theStylistaccording to "output target".