Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlighter with Linker #698

Merged
merged 19 commits into from
Nov 19, 2022
Merged

Highlighter with Linker #698

merged 19 commits into from
Nov 19, 2022

Conversation

HoshinoTented
Copy link
Contributor

@HoshinoTented HoshinoTented marked this pull request as draft November 19, 2022 04:18
@codecov
Copy link

codecov bot commented Nov 19, 2022 •
edited

Codecov Report

Merging #698 (9a93127) into main (f619ad5) will increase coverage by 0.36%.
The diff coverage is 62.37%.

@@             Coverage Diff              @@
##               main     #698      +/-   ##
============================================
+ Coverage     79.63%   80.00%   +0.36%     
- Complexity     2915     2984      +69     
============================================
  Files           261      266       +5     
  Lines          9492     9655     +163     
  Branches       1177     1184       +7     
============================================
+ Hits           7559     7724     +165     
+ Misses         1295     1279      -16     
- Partials        638      652      +14
Impacted Files Coverage Δ
...main/java/org/aya/cli/library/LibraryCompiler.java 82.55% <25.00%> (-0.33%) ⬇️
...rc/main/java/org/aya/cli/literate/Highlighter.java 46.72% <46.72%> (ø)
...i/src/main/java/org/aya/cli/repl/ReplCompiler.java 76.05% <66.66%> (+12.82%) ⬆️
...rc/main/java/org/aya/cli/repl/jline/JlineRepl.java 55.26% <83.33%> (-0.30%) ⬇️
...n/java/org/aya/cli/literate/HighlightInfoType.java 87.50% <87.50%> (ø)
base/src/main/java/org/aya/concrete/stmt/Stmt.java 100.00% <100.00%> (ø)
...va/org/aya/cli/library/json/LibraryConfigData.java 100.00% <100.00%> (+8.69%) ⬆️
.../main/java/org/aya/cli/literate/HighlightInfo.java 100.00% <100.00%> (ø)
...va/org/aya/cli/literate/utils/HighlighterUtil.java 100.00% <100.00%> (ø)
...rc/main/java/org/aya/cli/render/RenderOptions.java 74.68% <100.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@HoshinoTented HoshinoTented linked an issue Nov 19, 2022 that may be closed by this pull request
A faithful pretty printer #464
Closed
@HoshinoTented HoshinoTented self-assigned this Nov 19, 2022
@HoshinoTented HoshinoTented added this to the v0.24 milestone Nov 19, 2022
@ice1000
Copy link
Member

ice1000 commented Nov 19, 2022

Oh my Goodness 🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵♾️♾️♾️♾️♾️♾️♾️♾️♾️♾️♾️🎊🎊🎊🎊🎊🎊🎊🎊

1 similar comment
@imkiva
Copy link
Member

imkiva commented Nov 19, 2022

Oh my Goodness 🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵♾️♾️♾️♾️♾️♾️♾️♾️♾️♾️♾️🎊🎊🎊🎊🎊🎊🎊🎊

@HoshinoTented
Copy link
Contributor Author

Oh my Goodness 🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵🥵♾️♾️♾️♾️♾️♾️♾️♾️♾️♾️♾️🎊🎊🎊🎊🎊🎊🎊🎊

@ice1000 ice1000 marked this pull request as ready for review November 19, 2022 21:53
@ice1000
Copy link
Member

ice1000 commented Nov 19, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 19, 2022

Build succeeded:

@bors bors bot merged commit d9e04d3 into main Nov 19, 2022
@bors bors bot deleted the faithful-pp-v1 branch November 19, 2022 21:57
imkiva
imkiva reviewed Nov 20, 2022
View reviewed changes
cli/src/test/java/org/aya/cli/PlctReportTest.java
@Test public void generateReport() throws Exception {
var args = new MainArgs.PlctAction();
args.plctReport = true;
System.out.println(new PLCTReport().run(args));
Copy link
Member

@imkiva imkiva Nov 20, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test takes 7s to finish in my machine. And all the tests including this test take 11s.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LMFAO

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should enabled it only when "true".equals(System.getenv("CI"))

@ice1000 ice1000 mentioned this pull request Nov 28, 2022
Closed
@ice1000 ice1000 added the highlighter Faithful one label Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imkiva imkiva imkiva left review comments

@ice1000 ice1000 ice1000 left review comments

Assignees

@HoshinoTented HoshinoTented

Labels
highlighter Faithful one pretty print
Projects
None yet
Milestone
v0.24
Development

Successfully merging this pull request may close these issues.

A faithful pretty printer
3 participants
@HoshinoTented @ice1000 @imkiva