Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPL: decouple and fix #701

Merged
merged 3 commits into from
Nov 19, 2022
Merged

REPL: decouple and fix #701

merged 3 commits into from
Nov 19, 2022

Conversation

imkiva
Copy link
Member

@imkiva imkiva commented Nov 19, 2022

and highlight keywords using colors from configured color scheme...
and fix #683

@imkiva imkiva added the repl label Nov 19, 2022
@imkiva imkiva added this to the v0.24 milestone Nov 19, 2022
@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Merging #701 (71d6eba) into main (e43a0da) will increase coverage by 0.04%.
The diff coverage is 94.44%.

@@             Coverage Diff              @@
##               main     #701      +/-   ##
============================================
+ Coverage     79.62%   79.67%   +0.04%     
- Complexity     2910     2917       +7     
============================================
  Files           261      262       +1     
  Lines          9482     9484       +2     
  Branches       1176     1172       -4     
============================================
+ Hits           7550     7556       +6     
+ Misses         1295     1293       -2     
+ Partials        637      635       -2     
Impacted Files Coverage Δ
...rc/main/java/org/aya/cli/repl/jline/JlineRepl.java 55.26% <83.33%> (-0.30%) ⬇️
...rc/main/java/org/aya/cli/render/RenderOptions.java 74.68% <100.00%> (ø)
...i/src/main/java/org/aya/cli/repl/ReplCompiler.java 63.23% <100.00%> (ø)
...c/main/java/org/aya/cli/repl/ReplShapeFactory.java 91.66% <100.00%> (+21.66%) ⬆️
...src/main/java/org/aya/cli/repl/gk/GKReplLexer.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imkiva imkiva changed the title Decouple tools-repl with ij-parsing-core REPL: decouple and fix Nov 19, 2022
Copy link
Member

@ice1000 ice1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 19, 2022

Build succeeded:

@bors bors bot merged commit 46e38e6 into main Nov 19, 2022
@bors bors bot deleted the decouple branch November 19, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REPL cannot use literal patterns
2 participants