Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: remove a duplicate checkDeserialization() call #720

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Conversation

mio-19
Copy link
Contributor

@mio-19 mio-19 commented Nov 23, 2022

It is already in asConfig(@NotNull Path libraryRoot, @NotNull Function<String, Path> buildRootGen)

@mio-19 mio-19 requested a review from imkiva November 23, 2022 14:30
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #720 (1959d59) into main (b4707f0) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #720      +/-   ##
============================================
- Coverage     81.52%   81.51%   -0.01%     
+ Complexity     3011     3010       -1     
============================================
  Files           262      262              
  Lines          9578     9577       -1     
  Branches       1193     1193              
============================================
- Hits           7808     7807       -1     
  Misses         1119     1119              
  Partials        651      651              
Impacted Files Coverage Δ
...va/org/aya/cli/library/json/LibraryConfigData.java 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ice1000 ice1000 added this to the v0.25 milestone Nov 23, 2022
@ice1000
Copy link
Member

ice1000 commented Nov 23, 2022

Please add milestone and labels new time

@ice1000
Copy link
Member

ice1000 commented Nov 23, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 23, 2022

Build succeeded:

@bors bors bot merged commit 262da70 into main Nov 23, 2022
@bors bors bot deleted the remove-dup-chDe branch November 23, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants