Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix baka let and add some improvement #982

Merged
merged 4 commits into from
May 30, 2023
Merged

Fix baka let and add some improvement #982

merged 4 commits into from
May 30, 2023

Conversation

HoshinoTented
Copy link
Contributor

@HoshinoTented HoshinoTented commented May 30, 2023

Goals:

  • Nested interface for nested structure (copied from Let Term #979)
  • Better prettier for lambda
  • Fixes baka let which has redundant lambda

TODOs:

  • Better prettier for Pi (if Goal#2 is good) Pi is special

@HoshinoTented HoshinoTented added this to the v0.30 milestone May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #982 (98a9915) into main (7fb9a1b) will decrease coverage by 0.40%.
The diff coverage is 81.81%.

@@             Coverage Diff              @@
##               main     #982      +/-   ##
============================================
- Coverage     81.98%   81.58%   -0.40%     
+ Complexity     3475     3444      -31     
============================================
  Files           280      281       +1     
  Lines         10509    10526      +17     
  Branches       1271     1271              
============================================
- Hits           8616     8588      -28     
- Misses         1176     1211      +35     
- Partials        717      727      +10     
Impacted Files Coverage Δ
base/src/main/java/org/aya/concrete/Expr.java 85.63% <50.00%> (-0.42%) ⬇️
...c/main/java/org/aya/prettier/ConcretePrettier.java 82.46% <61.53%> (-0.65%) ⬇️
base/src/main/java/org/aya/generic/Nested.java 100.00% <100.00%> (ø)
base/src/main/java/org/aya/tyck/ExprTycker.java 84.00% <100.00%> (-0.15%) ⬇️
...c/main/java/org/aya/tyck/tycker/LetListTycker.java 100.00% <100.00%> (ø)
.../src/main/java/org/aya/tyck/tycker/MockTycker.java 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

ice1000
ice1000 previously approved these changes May 30, 2023
base/src/main/java/org/aya/generic/Nested.java Outdated Show resolved Hide resolved
@HoshinoTented
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented May 30, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 61e7683 into main May 30, 2023
4 of 6 checks passed
@bors bors bot deleted the fix-baka-let branch May 30, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants