This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
[DNM] [WIP] Library #652
Merged
[DNM] [WIP] Library #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ice1000
reviewed
Aug 22, 2021
ice1000
reviewed
Aug 22, 2021
base/src/main/java/org/aya/concrete/resolve/module/FileModuleLoader.java
Outdated
Show resolved
Hide resolved
base/src/main/java/org/aya/concrete/resolve/module/FileModuleLoader.java
Outdated
Show resolved
Hide resolved
Some changes are cherry picked as #653 |
imkiva
commented
Aug 23, 2021
base/src/main/java/org/aya/concrete/resolve/module/FileModuleLoader.java
Show resolved
Hide resolved
base/src/main/java/org/aya/concrete/resolve/module/FileModuleLoader.java
Outdated
Show resolved
Hide resolved
base/src/main/java/org/aya/concrete/resolve/module/FileModuleLoader.java
Outdated
Show resolved
Hide resolved
This was
linked to
issues
Aug 23, 2021
Closed
Merged
ice1000
force-pushed
the
library
branch
7 times, most recently
from
August 26, 2021 20:01
b605d07
to
83936e3
Compare
ice1000
reviewed
Aug 27, 2021
ice1000
approved these changes
Aug 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imkiva proposed to merge this early. Let's do this.
I've done the review. @imkiva please create new issue with the leftovers. |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a library system for Aya.
TODOs:
If we are going to make package manager a Java project, I propose we could move all the code from cli to package manager