Implement query for lirc programs #32
Conversation
|
Fixes #2 |
seanyoung
force-pushed
the
query
branch
2 times, most recently
from
b35522d
to
d2c911f
Compare
aya/src/programs/mod.rs
Outdated
| pub struct ProgramInfo(bpf_prog_info); | ||
|
|
||
| impl ProgramInfo { | ||
| pub fn name(&self) -> Option<String> { |
There was a problem hiding this comment.
Shouldn't this return &[u8]? It's valid for the name not to be utf8, I think callers should (optionally) do the conversion here
There was a problem hiding this comment.
Shouldn't this return &[u8]? It's valid for the name not to be utf8, I think callers should (optionally) do the conversion here
I just realised that we use String for program names everywhere else so I'm leaving this up to you, I'm ok with either
There was a problem hiding this comment.
So we have both of them now as an option: fn name() which gives you &[u8] and fn name_as_str() which returns Option<&str>.
| @@ -533,3 +579,24 @@ impl_try_from_program!( | |||
| CgroupSkb, | |||
| LircMode2 | |||
| ); | |||
|
|
|||
| pub struct ProgramInfo(bpf_prog_info); | |||
There was a problem hiding this comment.
Can you add some docs for the struct and the accessors please?
There was a problem hiding this comment.
I've added some rustdoc (a bit rudimentary)
Signed-off-by: Sean Young <sean@mess.org>
|
thank you! |
Signed-off-by: Sean Young sean@mess.org