aya: expose BPF verifier log level configuration #371
Conversation
✅ Deploy Preview for aya-rs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
aya/src/bpf.rs
Outdated
| /// # Ok::<(), aya::BpfError>(()) | ||
| /// ``` | ||
| /// | ||
| pub fn verifier_log_level(&mut self, level: u32) -> &mut BpfLoader<'a> { |
There was a problem hiding this comment.
I think instead of u32 we should probably have an enum:
#[non_exhaustive]
#[repr(u32)]
pub enum VerifierLogLevel {
Default = 4,
Verbose = 1,
Debug = 7,
}
See https://github.com/torvalds/linux/blob/f16214c102f0f64b2f3546e989498525bd7b7708/include/linux/bpf_verifier.h#L419. The Default/Verbose value correspond to what libbpf does too.
There was a problem hiding this comment.
Updated it here, changed the names and added some valid configurations.
Let me know if you still prefer the above variants, I just felt like this it was slightly clearer.
There was a problem hiding this comment.
Could also change it up so that is similar to a bitmap, e.g. set it up like:
VerifierLogLevel::default().level_1(true).stats(true)But might be too verbose for something like this.
There was a problem hiding this comment.
Updated it here, changed the names and added some valid configurations.
Let me know if you still prefer the above variants, I just felt like this it was slightly clearer.
I don't think this is cleaner - in fact it took me a good 10 minutes yesterday to understand why those names were used in the kernel and how they work. The names are bad, and I don't think we should surface the fact that log level s are implemented as a bitfield in the kernel all the way up to the aya API.
There was a problem hiding this comment.
We should also have a Disable = 0 variant in addition to the ones I initially suggested tho
dave-tucker
added
feature
Hi!
Simple change that allows configuring verifier log level using
BpfLoader.Reducing the log level is very useful when debugging since the last line of the verifier error is its cause, so when the buffer is out of space you can't see the cause.
For reference: change discussed here