Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aya-log: Unify IP format hints into one, repsesent it by :i token #599

Merged
merged 1 commit into from
May 27, 2023

Commits on May 2, 2023

  1. aya-log: Unify IP format hints into one, repsesent it by :i token

    Having separate format hints and tokens per IP address family is
    unnecessary, since they are represented by different types and we handle
    format hints for each type separately. So we can just have one format
    hint.
    
    Also, we should be consistent with the format strings grammar in
    Rust[0]. The `type` token, which is mapped to formatting traits, usually
    consists of one letter[1] (and optional `?` for `Debug` trait, but that
    doesn't matter for us). It shouldn't consist of multiple letters. Our
    `:ipv4` and `:ipv6` tokens were clearly breaking that convention, so we
    should rather switch to something with one letter - hence `:i`.
    
    [0] https://doc.rust-lang.org/std/fmt/#syntax
    [1] https://doc.rust-lang.org/std/fmt/#formatting-traits
    vadorovsky committed May 2, 2023
    Configuration menu
    Copy the full SHA
    9e0a3aa View commit details
    Browse the repository at this point in the history