aya: introduce include_bytes_aligned!() macro #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willfindlay
force-pushed
the
load_include_bytes
branch
from
3c93d7d
to
353a461
Compare
alessandrod
requested changes
Oct 25, 2021
willfindlay
force-pushed
the
load_include_bytes
branch
from
353a461
to
1751ef4
Compare
|
@alessandrod I've made the requested changes. Thanks! |
willfindlay
force-pushed
the
load_include_bytes
branch
2 times, most recently
from
090ec1b
to
56fbeb0
Compare
|
Just had to fix a couple of typos in the documentation. Should be good to go now. |
This is a helper macro that can be used to include bytes at compile-time that can then be used in Bpf::load(). Unlike std's include_bytes!(), this macro also ensures that the resulting byte array is correctly aligned so that it can be parsed as an ELF binary. Signed-off-by: William Findlay <william@williamfindlay.com>
willfindlay
force-pushed
the
load_include_bytes
branch
from
56fbeb0
to
4df4e9c
Compare
|
Thank you! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a helper macro that can be used to include bytes at compile-time that can then be
used in Bpf::load(). Unlike std's include_bytes!(), this macro also ensures that the
resulting byte array is correctly aligned so that it can be parsed as an ELF binary.
The motivation for this patch is that users have been confused in the past when trying to just use
include_bytes!(). See #24.Signed-off-by: William Findlay william@williamfindlay.com